Merged
Conversation
Instead of adding a string representation of errno to an error message, wrap the actual errno using %w. Signed-off-by: Kir Kolyshkin <[email protected]>
The error from os.Readfile already contains file name and operation that failed, there is no need to wrap it. Signed-off-by: Kir Kolyshkin <[email protected]>
Error messages returned by GetHandle and GetSymbolPointer are already descriptive enough so they don't need to be wrapped. Signed-off-by: Kir Kolyshkin <[email protected]>
Using errors.New to make an error and then using %v to call its Error method to add a string to the message seems unnecessary. Simplify it by using the string as is. Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
It makes little sense to have very detailed error messages saying which response field we failed to typecast. Let's use more generic "failed to parse response" error message, and show what we tried to parse. Signed-off-by: Kir Kolyshkin <[email protected]>
...if there are no %-style arguments. Signed-off-by: Kir Kolyshkin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see individual commits for details.