Merged
Conversation
Luap99
reviewed
Aug 19, 2025
import1/dbus_test.go
Outdated
| ) | ||
| for range 5 { | ||
| time.Sleep(dur) | ||
| out, err = exec.Command("machinectl", "image-status", name).CombinedOutput() |
Collaborator
There was a problem hiding this comment.
that is not removing anything, is it? Would this not need to call remove?
Collaborator
Author
There was a problem hiding this comment.
Ah! It was remove and when I was doing some testing trying to remove sleep.
Fixed.
This test was leaving files and directories under $PWD. Use t.TempDir to avoid it. Signed-off-by: Kir Kolyshkin <[email protected]>
TestImport functions create some artefacts under /var/lib/machines which require "machinectl remove" invocation to clean up. Unfortunately, Import operations are async, meaning we either have to listen to transfer events to ensure they are completed, or just sleep for some time. Since this is a test I'd like to keep things simple. Signed-off-by: Kir Kolyshkin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import1: use t.TempDir
This test was leaving files and directories under $PWD.
Use t.TempDir to avoid it.
import1: fix TestImport* cleanup
TestImport functions create some artefacts under /var/lib/machines which
require "machinectl remove" invocation to clean up.
Unfortunately, Import operations are async, meaning we either have to
listen to transfer events to ensure they are completed, or just sleep
for some time. Since this is a test I'd like to keep things simple.