Bump go to 1.23, fix tests, add more images#464
Merged
Luap99 merged 9 commits intocoreos:mainfrom Aug 12, 2025
Merged
Conversation
Luap99
reviewed
Aug 11, 2025
Collaborator
Luap99
left a comment
Luap99
left a comment
There was a problem hiding this comment.
Thanks, that all makes sense
Looks like the container test all ship an outdated go? I guess from the normal LTS repos. Likely need to sideload go there.
kolyshkin
changed the title
kolyshkin
force-pushed
the
go123
branch
11 times, most recently
from
2709a7d to
fe1e568
Compare
Move the logic of running tests in a container to the script, as it is easy to work with. No change in functionality, except for shorter sleep duration. Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
go123
branch
7 times, most recently
from
be69c8f to
128647a
Compare
Signed-off-by: Kir Kolyshkin <[email protected]>
Instead of relying a distro to provide a recent Go version, let's install it ourselves from a binary distribution. Signed-off-by: Kir Kolyshkin <[email protected]>
Currently, go 1.23 is the "old" supported version, meaning the older versions are no longer supported. Let's use it as a minimally required version. Signed-off-by: Kir Kolyshkin <[email protected]>
In some cases, TestListJobs fails like this: methods_test.go:712: oneshot.service job not found in list This happens because 'ExecStart=/bin/sh sleep 400' doesn't really run sleep; it merely fails. So, the job is queued and then ExecStart fails instantly, and if the test checks the job status after the failure, the test fails. Fix the ExecStart. While at it, - fix unit description; - remove ExecStartPost as it's useless (and also wrong). Signed-off-by: Kir Kolyshkin <[email protected]>
On newer distros, some session paths have c instead of _. Fix the test accordingly. Signed-off-by: Kir Kolyshkin <[email protected]>
The output also missed a newline. Signed-off-by: Kir Kolyshkin <[email protected]>
This test assumed the first entry in systemd-journald.service log comes with MESSAGE_ID set. This is not true for modern distros, so the test fails. Add a loop to scan for MESSAGE_ID, and skip if not found. Co-authored-by: Claude Code Signed-off-by: Kir Kolyshkin <[email protected]>
1. Replace ubuntu 22.04 with 24.04 2. Add debian trixie (13, "stable"). 3. Add fedora. Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
changed the title
kolyshkin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see individual commits for details.
High level overview:
These are moved to a followup PR: