Merged
Conversation
5 tasks
Contributor
Author
|
Another option would be to make this explicitly a |
Luap99
reviewed
Jul 31, 2025
Collaborator
Luap99
left a comment
Luap99
left a comment
There was a problem hiding this comment.
Are the LISTEN_ env used somehwere else outside of systemd. In general just using linux as build tag seems reasonable to me as long as it is not used on other OS somehow?
@kolyshkin WDYT?
Collaborator
|
I'd just add |
plan9 doesn't have syscall.CloseOnExec, causing anything using `activation` to fail when building on plan9: ``` 2024/05/03 12:12:51 Failed to run [go build --ldflags -s -X github.com/rclone/rclone/fs.Version=v1.67.0-beta.7911.f8ce568ca.merge -trimpath -o rclone-v1.67.0-beta.7911.f8ce568ca.merge-plan9-386/rclone -tags ..]: exit status 1 2024/05/03 12:12:51 Command output was: Error: ../../../../go/pkg/mod/github.com/coreos/go-systemd/[email protected]/activation/files_unix.go:60:11: undefined: syscall.CloseOnExec ```
flokli
force-pushed
the
activation-plan9-stub
branch
from
553c525 to
61f1d85
Compare
Contributor
Author
Done! PTAL. |
kolyshkin
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plan9 doesn't have syscall.CloseOnExec, causing anything using
activationto fail when building on plan9:Seen on rclone/rclone#7801