This repository was archived by the owner on Jan 30, 2020. It is now read-only.
fleetctl: support truthy values in boolean unit options #1574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
job/job.go
Outdated
|
|
||
| // isTruthyValue returns true if a given string is any of "truthy" value, | ||
| // i.e. "true", "yes", "1", "on", or "t". | ||
| func isTruthyValue(astr string) bool { |
Contributor
There was a problem hiding this comment.
Could you add a test table for this function please? (I know it seems incredibly simplistic but stranger places have tripped us up before)
also s/astr/s/, prefer simpler variable names in go
Support truthy values in boolean unit options(true, yes, on, 1, t). Originally written by wuqixuan <[email protected]> Supersedes coreos#1271 Fixes: coreos#1108
dongsupark
force-pushed
the
dongsu/fleetctl-truthy-values
branch
from
6332d71 to
fabe005
Compare
Contributor
|
LGTM |
Author
|
Done.
|
Author
|
Merged #1574. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support truthy values in boolean unit options(true, yes, on, 1, t).
Originally written by @wuqixuan
Supersedes #1271
Fixes: #1108