This repository was archived by the owner on Jan 30, 2020. It is now read-only.
[WIP] fleetd: register heartbeat only for the first attempt #1563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now support detecting the existing machine-id on startup. Fixes coreos#1241 coreos#615
Export NewMachineID() from the Cluster interface, to make it available for functional tests. This will be necessary for following test cases where machine IDs need to be regenerated.
A new test TestDetectMachineId checks if a etcd registration fails when a duplicated entry for /etc/machine-id gets registered to different machines. Note that it's expected to fail in this case. Goal of the test is to cover the improvement patch by @wuqixuan ("fleetd: Detecting the existing machine-id"). See also coreos#1288, coreos#1241, coreos#615. Suggested-by: Olaf Buddenhagen <[email protected]> Cc: wuqixuan <[email protected]>
When beating the Heart for the 1st time, call Heart.Register() to avoid such a case of registering machine with the same ID. Starting from the next heartbeat, however, call Heart.Beat() to allow registration with the same ID. That way fleetd can handle the machine presence in a graceful way. Suggested-by: wuqixuan <[email protected]> Fixes: coreos#750
Contributor
|
@dongsupark this sounds wrong to me: doesn't it mean that the followup attempts will "steal" the ID from another instance if there is a conflict?... (Haven't really thought it through in detail though -- so I might be missing something here...) |
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When beating the Heart for the 1st time, call
Heart.Register()to avoid such a case of registering machine with the same ID. Starting from the next heartbeat, however, callHeart.Beat()to allow registration with the same ID. That way fleetd can handle the machine presence in a graceful way.Suggested-by: @wuqixuan
Fixes: #750
This PR depends on #1561.
NOTE: this is still experimental. do not merge it yet please!