Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Conversation

@kayrus
Copy link
Contributor

@kayrus kayrus commented Apr 18, 2016

resolves #1536
obsoletes #1537

Not sure whether I did that correctly... Here are my steps:

find . -name '*.go' -exec sed -i 's#github.com/coreos/fleet/Godeps/_workspace/src/##g' {} \;
cat Godeps/Godeps.json | grep -v github.com/coreos/fleet | awk -F"[:\", \t]*" '/ImportPath|Rev/ { if ($2 == "ImportPath") { printf("%s ",$3) } else { printf("%s\n",$3)} }' > vendor.manifest
git add vendor.manifest
mkdir vendor
git mv Godeps/_workspace/src/* vendor/
git rm -r Godeps
go fmt registry/fake.go

Then fixed:

  • .travis.yml - add new env
  • build-env - remove legacy support for go 1.4

@kayrus kayrus added this to the v0.13.0 milestone Apr 18, 2016
@kayrus kayrus self-assigned this Apr 18, 2016
@kayrus kayrus force-pushed the kayrus/vendor2 branch 3 times, most recently from cd3a404 to f1bce0d Compare April 18, 2016 10:41
@reneengelhard
Copy link
Contributor

looks good to me, at least it still builds, CI works, etc :)

@kayrus kayrus force-pushed the kayrus/vendor2 branch 2 times, most recently from ef70ce0 to d4cfb9e Compare April 29, 2016 08:05
@dongsupark
Copy link

Looks good. My local build also works.

@dongsupark
Copy link

dongsupark commented May 9, 2016

After a short offline discussion, we (hector, kayrus and me) agreed that we'd need to merge this PR to avoid further pain.

@hectorj2f
Copy link
Contributor

+1, It would make the live easier to merge new PRs which require additional go libraries. :)

@dongsupark dongsupark merged commit 8685cfb into coreos:master May 9, 2016
@dongsupark
Copy link

Merged. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: replace gopdep with vendor

5 participants