Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Conversation

@kayrus
Copy link
Contributor

@kayrus kayrus commented Mar 29, 2016

resolves #565

@tixxdz
Copy link
Contributor

tixxdz commented Mar 31, 2016

@kayrus @jonboulle it seems that some of the library tests (not related to fleet) were removed, where in upstream they are still there. Any hint on this ?

thanks!

@kayrus
Copy link
Contributor Author

kayrus commented Mar 31, 2016

I suppose it is godep's behavior.

UPD: Test files and testdata directories can be saved by adding -t. (c). @jonboulle should I add tests?

@kayrus
Copy link
Contributor Author

kayrus commented Mar 31, 2016

I use go1.5.3 and godep v60. Even with -t godep doesn't preserve test files.

@jonboulle
Copy link
Contributor

Not including tests is fine. I'm surprised -t doesn't work for you, sounds like a bug..

@jonboulle
Copy link
Contributor

Thanks @kayrus ! LGTM

@jonboulle jonboulle merged commit 3e14a49 into coreos:master Mar 31, 2016
@kayrus
Copy link
Contributor Author

kayrus commented Mar 31, 2016

@jonboulle yep, it is a bug tools/godep#405

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

handshake failed: ssh: unexpected message type 1 (expected 52)

3 participants