This repository was archived by the owner on Jan 30, 2020. It is now read-only.
fleetctl:test: add a new test for submit command #1473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 7, 2016
dongsupark
force-pushed
the
dongsu/fleetctl-submit-test
branch
from
d0666f2 to
23bc63f
Compare
Author
|
I updated the tree. Changes are:
|
Contributor
|
lgtm, @jonboulle #1466 then this one. Thanks! |
Contributor
|
Please rebase |
dongsupark
force-pushed
the
dongsu/fleetctl-submit-test
branch
from
23bc63f to
2647b45
Compare
Author
|
@jonboulle rebased. |
| 0, | ||
| }, | ||
| { | ||
| "submit same unit from an available template", |
Contributor
There was a problem hiding this comment.
Might as well add some cases that mix non-available/available, and same units, etc.
Introduce a new test for the fleetctl submit command, not only for simple units, but also for template units.
dongsupark
force-pushed
the
dongsu/fleetctl-submit-test
branch
from
2647b45 to
b6cc520
Compare
Author
|
Rebased and updated.
|
Contributor
|
LGTM, thnaks |
jonboulle
added a commit
that referenced
this pull request
Mar 9, 2016
fleetctl:test: add a new test for submit command
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new test for the fleetctl submit command,
not only for simple units, but also for template units.
NOTE: this PR depends on #1466, which is still pending.