This repository was archived by the owner on Jan 30, 2020. It is now read-only.
fleetctl:test: improve the start test and make sure that it handles templates #1466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Waiting on semaphore to be fixed.. |
Contributor
Author
|
@jonboulle the fix for semaphore is here: #1467 |
added 2 commits
March 4, 2016 17:37
…ate units This is a preparation patch for the next start test patch that will try to create and start units from a template unit
…emplates Since we create units from a template unit, there is a real wait operation. To avoid that and be able to really test functions, just make template units global by default, later new units will be global and we won't wait forever to reach the targetstate we just assume the Desiredstate.
tixxdz
force-pushed
the
tixxdz/fleetctl-unit-tests-start-v2
branch
from
e492091 to
bf17621
Compare
Contributor
Author
|
tests pass, thanks! |
jonboulle
added a commit
that referenced
this pull request
Mar 8, 2016
…rt-v2 fleetctl:test: improve the start test and make sure that it handles templates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch 1: This is a preparation patch for the next start test patch that will try to create and start units from a template unit.
Patch 2: improve the start test and make sure that it handles templates