This repository was archived by the owner on Jan 30, 2020. It is now read-only.
fleetctl: more tests for start load command and template path #1460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 3, 2016 12:16
…ts by default Since we create units from a template unit, there is a real wait operation. To avoid that and be able to really test functions, just make template units global by default, later new units will be global and we won't wait forever to reach the targetstate we just assume the Desiredstate
If we fail just return, otherwise we may print other confusing errors.
If we fail just return, otherwise we may print other confusing errors.
Contributor
Author
|
@dongsupark thank you, done! |
|
@tixxdz looks good. :-) |
Contributor
Author
|
@jonboulle ok hold on this one, I opened new PR for load #1464 and new ones are coming, will close this one after that. |
Contributor
Author
|
@jonboulle second one #1465 ,and the next one will be on top Thank you! |
Contributor
Author
|
@dongsupark @jonboulle last series of this patches is here: #1466 |
Contributor
Author
|
The first two PRs were merged, the last ons is #1466 , so closing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more tests for fleetctl start and load commands, and make sure that the template unit path also works as expected. While we are it improve fleetctl test helper functions.