This repository was archived by the owner on Jan 30, 2020. It is now read-only.
fleetd: Detecting the existing machine-id #1288
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heart/heart.go
Outdated
Contributor
Author
There was a problem hiding this comment.
Yes, has grammar issue, already updated.
server/server.go
Outdated
Contributor
There was a problem hiding this comment.
Add some context to this error message. Perhaps "Failed machine heartbeat: %v"
Now support detecting the existing machine-id on startup. Fixes coreos#1241 coreos#615
Contributor
Author
|
@bcwaldon ,totally agree with your comments, updated as per your suggestion. Currently the result is like: |
Contributor
Author
|
@bcwaldon , the solution with my latest code has one problem. If the fleetd is killed by sigkill which can not be catched, the fleetd's registration will always be failing. |
Contributor
Author
|
Gently ping @jonboulle , I thought over again about the modification. I think the solution is fine. If the fleetd is killed by sigkill which can not be catched, the fleetd's registration will fail until the TTL is timeout. So my code is correct I think. |
Contributor
|
This seems pretty reasonable, but since it's quite an important change, can we get a functional test for it? |
dongsupark
pushed a commit
to endocode/fleet
that referenced
this pull request
Apr 19, 2016
A new test TestDetectMachineId checks if a etcd registration fails when a duplicated entry for /etc/machine-id gets registered to different machines. Note that it's expected to fail in this case. Goal of the test is to cover the improvement patch by @wuqixuan ("fleetd: Detecting the existing machine-id"). See also coreos#1288, coreos#1241, coreos#615. Suggested-by: Olaf Buddenhagen <[email protected]> Cc: wuqixuan <[email protected]>
dongsupark
pushed a commit
to endocode/fleet
that referenced
this pull request
Apr 20, 2016
A new test TestDetectMachineId checks if a etcd registration fails when a duplicated entry for /etc/machine-id gets registered to different machines. Note that it's expected to fail in this case. Goal of the test is to cover the improvement patch by @wuqixuan ("fleetd: Detecting the existing machine-id"). See also coreos#1288, coreos#1241, coreos#615. Suggested-by: Olaf Buddenhagen <[email protected]> Cc: wuqixuan <[email protected]>
dongsupark
pushed a commit
to endocode/fleet
that referenced
this pull request
Apr 21, 2016
A new test TestDetectMachineId checks if a etcd registration fails when a duplicated entry for /etc/machine-id gets registered to different machines. Note that it's expected to fail in this case. Goal of the test is to cover the improvement patch by @wuqixuan ("fleetd: Detecting the existing machine-id"). See also coreos#1288, coreos#1241, coreos#615. Suggested-by: Olaf Buddenhagen <[email protected]> Cc: wuqixuan <[email protected]>
dongsupark
pushed a commit
to endocode/fleet
that referenced
this pull request
Apr 21, 2016
A new test TestDetectMachineId checks if a etcd registration fails when a duplicated entry for /etc/machine-id gets registered to different machines. Note that it's expected to fail in this case. Goal of the test is to cover the improvement patch by @wuqixuan ("fleetd: Detecting the existing machine-id"). See also coreos#1288, coreos#1241, coreos#615. Suggested-by: Olaf Buddenhagen <[email protected]> Cc: wuqixuan <[email protected]> Cc: Djalal Harouni <[email protected]>
dongsupark
pushed a commit
to endocode/fleet
that referenced
this pull request
Apr 21, 2016
A new test TestDetectMachineId checks if a etcd registration fails when a duplicated entry for /etc/machine-id gets registered to different machines. Note that it's expected to fail in this case. Goal of the test is to cover the improvement patch by @wuqixuan ("fleetd: Detecting the existing machine-id"). See also coreos#1288, coreos#1241, coreos#615. Suggested-by: Olaf Buddenhagen <[email protected]> Cc: wuqixuan <[email protected]> Cc: Djalal Harouni <[email protected]>
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now support detecting the existing machine-id on startup.
Fixes #1241 #615