This repository was archived by the owner on Jan 30, 2020. It is now read-only.
fleetctl: Support truthy values in boolean unit options #1271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support truthy values in boolean unit options(yes, on, 1, t) Fixes coreos#1108
Contributor
There was a problem hiding this comment.
Break this logic out into a helper function and test it independently of Unit.IsGlobal
dongsupark
pushed a commit
to dongsupark/fleet
that referenced
this pull request
Apr 27, 2016
Support truthy values in boolean unit options(yes, on, 1, t). Originally written by wuqixuan <[email protected]> Supersedes coreos#1271 Fixes: coreos#1108
dongsupark
pushed a commit
to dongsupark/fleet
that referenced
this pull request
Apr 29, 2016
Support truthy values in boolean unit options(yes, on, 1, t). Originally written by wuqixuan <[email protected]> Supersedes coreos#1271 Fixes: coreos#1108
dongsupark
pushed a commit
to dongsupark/fleet
that referenced
this pull request
Apr 29, 2016
Support truthy values in boolean unit options(true, yes, on, 1, t). Originally written by wuqixuan <[email protected]> Supersedes coreos#1271 Fixes: coreos#1108
dongsupark
pushed a commit
to dongsupark/fleet
that referenced
this pull request
May 18, 2016
Support truthy values in boolean unit options(true, yes, on, 1, t). Originally written by wuqixuan <[email protected]> Supersedes coreos#1271 Fixes: coreos#1108
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support truthy values in boolean unit options(yes, on, 1, t)
Fixes #1108