Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

fleetctl: Adding Restart Command #1082

Closed
divideandconquer wants to merge 5 commits into from
Closed

fleetctl: Adding Restart Command #1082

divideandconquer wants to merge 5 commits into from

Conversation

@divideandconquer
Copy link

@divideandconquer divideandconquer commented Jan 6, 2015

This allows end users to perform rolling restarts on units easily with one command.

This pull request uses the existing cAPI.SetUnitTargetState function to load and then launch each unit since setting up a passthrough for the systemctl restart command is overly complex and seems to be against the restful nature of the system.

@divideandconquer
Copy link
Author

divideandconquer commented Jan 6, 2015

Just noticed that this adds similar functionality as PR #961

@bcwaldon
Copy link
Contributor

bcwaldon commented May 1, 2015

@davidreynolds if you have time, could you squash your commits down and update the commit message per CONTRIBUTING.md?

@bcwaldon
Copy link
Contributor

bcwaldon commented May 1, 2015

#975

@hhoover hhoover mentioned this pull request Jun 1, 2015
Closed
@bcwaldon
Copy link
Contributor

bcwaldon commented Jul 9, 2015

Also in progress at #1238

@arthur-c
Copy link

arthur-c commented Jan 21, 2016

Hi,
I bump this PR, a restart command could be handy.
I'm also destroying/starting units pretty often, an option --destroy (or force) to the restart command could also be appreciated.

@jonboulle jonboulle added this to the v0.13.0 milestone Jan 22, 2016
@tixxdz
Copy link
Contributor

tixxdz commented Apr 8, 2016

Hi @arthur-c thank you for the bump.

Could you please also review and comment in this #1238 PR , hmm it seems that conversation moved into that PR ?

A quick look suggests the patches are the same, I guess same approach, so it would be nice if you could share your thoughts here, or better on that PR.

Thanks again!

@antrik
Copy link
Contributor

antrik commented Apr 8, 2016

@tixxdz the description in #1238 explicitly states that it's just a sqash of this one...

@tixxdz
Copy link
Contributor

tixxdz commented Apr 18, 2016

The update on this one and how this should be used implemented is here:
#975 (comment)

Closing this one, thank you all!

@tixxdz tixxdz closed this Apr 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

priority/Pmaybe reviewed/needs more information

Projects

None yet

Milestone

v0.13.0

Development

Successfully merging this pull request may close these issues.

6 participants

@divideandconquer @bcwaldon @arthur-c @tixxdz @antrik @jonboulle