This repository was archived by the owner on Jan 30, 2020. It is now read-only.
This repository was archived by the owner on Jan 30, 2020. It is now read-only.
fleet should detect machines with the same machine-id #1241
Description
fleet could provide a better error message when it detects machines with the same machine-id. I have 5 nodes with the same machine-id which cause fleet to log the following errors:
Jun 05 04:49:49 localhost fleet[11544]: ERROR engine.go:218: Engine leadership lost, renewal failed: 101: Compare failed ([260 != 261]) [261]
Jun 05 04:49:53 localhost fleet[11544]: ERROR engine.go:218: Engine leadership lost, renewal failed: 101: Compare failed ([262 != 264]) [264]
Jun 05 04:49:57 localhost fleet[11544]: ERROR engine.go:218: Engine leadership lost, renewal failed: 101: Compare failed ([265 != 266]) [269]
Jun 05 04:50:01 localhost fleet[11544]: ERROR engine.go:218: Engine leadership lost, renewal failed: 101: Compare failed ([271 != 272]) [272]
Jun 05 04:50:05 localhost fleet[11544]: ERROR engine.go:218: Engine leadership lost, renewal failed: 101: Compare failed ([273 != 274]) [274]
Jun 05 04:50:09 localhost fleet[11544]: ERROR engine.go:218: Engine leadership lost, renewal failed: 101: Compare failed ([275 != 277]) [277]
Jun 05 04:50:13 localhost fleet[11544]: ERROR engine.go:218: Engine leadership lost, renewal failed: 101: Compare failed ([278 != 279]) [283]
If you look at the output from the fleet list-machines command you see the root cause:
$ /opt/bin/fleetctl --endpoint=http://10.20.132.53:2379 list-machines
MACHINE IP METADATA
3f44ca14... 10.20.132.53 -
core@localhost /opt/bin $ /opt/bin/fleetctl --endpoint=http://10.20.132.53:2379 list-machines
MACHINE IP METADATA
3f44ca14... 10.20.132.56 -
core@localhost /opt/bin $ /opt/bin/fleetctl --endpoint=http://10.20.132.53:2379 list-machines
MACHINE IP METADATA
3f44ca14... 10.20.132.57 -
core@localhost /opt/bin $ /opt/bin/fleetctl --endpoint=http://10.20.132.53:2379 list-machines
MACHINE IP METADATA
3f44ca14... 10.20.132.55 -
core@localhost /opt/bin $ /opt/bin/fleetctl --endpoint=http://10.20.132.53:2379 list-machines
MACHINE IP METADATA
3f44ca14... 10.20.132.55 -
Each machine is taking turns registering with the same machine-id.