*: Prevented unit's Contents modification

kayrus · kayrus · commit a23ce6fccc10 · 2016-03-30T11:33:27.000+02:00
Resolves #1514 The problem was caused by the [code optimization](#1376). Before that each unit was stored in its own variable. Then this code was optimized and units became stored in hash map (`getAllUnitsHashMap`). Each hash was assigned to the unit's pointer. And when template unit was checked by `requirements()` function, its content was modified by `values[i] = unitPrintf(v, *uni)` code. Once templated unit was modified, all related units (which have same hash) were modified too, because they are related to one pointer.
diff --git a/job/job.go b/job/job.go
@@ -175,11 +175,14 @@ func (j *Job) requirements() map[string][]string {
 		}
 
 		if uni != nil {
+			processedValues := make([]string, len(values))
 			for i, v := range values {
-				values[i] = unitPrintf(v, *uni)
+				processedValues[i] = unitPrintf(v, *uni)
 			}
+			requirements[key] = processedValues
+		} else {
+			requirements[key] = values
 		}
-		requirements[key] = values
 	}
 
 	return requirements

Original file line number	Diff line number	Diff line change
`@@ -175,11 +175,14 @@ func (j *Job) requirements() map[string][]string {`
`175`	`175`	`}`
`176`	`176`
`177`	`177`	`if uni != nil {`
	`178`	`+ processedValues := make([]string, len(values))`
`178`	`179`	`for i, v := range values {`
`179`		`- values[i] = unitPrintf(v, *uni)`
	`180`	`+ processedValues[i] = unitPrintf(v, *uni)`
`180`	`181`	`}`
	`182`	`+ requirements[key] = processedValues`
	`183`	`+ } else {`
	`184`	`+ requirements[key] = values`
`181`	`185`	`}`
`182`		`- requirements[key] = values`
`183`	`186`	`}`
`184`	`187`
`185`	`188`	`return requirements`