This repository was archived by the owner on Sep 18, 2020. It is now read-only.
config: add etcd authentication #418
Merged
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@jipperinbham could you please rebase this PR? |
Contributor
|
@crawford this PR should be reconciled with @jonboulle and coreos/fleet#1506 |
Contributor
|
Yeah, we have to wait on flannel as well. |
Contributor
|
@jipperinbham can you squash your commits and rebase onto master? It looks like we can finally merge this. |
Contributor
|
Ping. |
expose username and password configuration options for flannel, fleet, and locksmith to etcd Addresses flannel-io/flannel#419 and coreos/fleet#1505
jipperinbham
force-pushed
the
etcd-basic-auth
branch
from
56077cf to
518b456
Compare
Contributor
Author
|
@crawford sorry about that, squashed and rebased |
crawford
approved these changes
Dec 8, 2016
Contributor
|
Thanks again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expose username and password configuration options for flannel, fleet, and locksmith to etcd
Addresses flannel-io/flannel#419 and coreos/fleet#1505