This repository was archived by the owner on Sep 18, 2020. It is now read-only.
Copy Ignition base/user configs from OEM to Ignition system dir#135
Merged
bgilbert merged 2 commits intocoreos:masterfrom Dec 6, 2017
bgilbert:external-oem-configs
Merged
Copy Ignition base/user configs from OEM to Ignition system dir#135bgilbert merged 2 commits intocoreos:masterfrom bgilbert:external-oem-configs
bgilbert merged 2 commits intocoreos:masterfrom
bgilbert:external-oem-configs
Conversation
This was referenced Dec 4, 2017
dm0-
approved these changes
Dec 4, 2017
| Requires=ignition-disks.service | ||
| After=ignition-disks.service | ||
| Requires=ignition-setup.service ignition-disks.service | ||
| After=ignition-setup.service ignition-disks.service |
Contributor
There was a problem hiding this comment.
This looks redundant with the Requires/After in ignition-disks.service, but it doesn't hurt.
Contributor
Author
There was a problem hiding this comment.
Yep, it's not the only redundant dependency in ignition-files.service. I put it in for consistency and for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For coreos/ignition#475.