Skip to content

Fix panic from avg(x ORDER BY y) (and more) (#25711) - #437

Merged
masonh22 merged 2 commits into
v55from
take-udf-fixes
Sep 28, 2026
Merged

masonh22 merged 2 commits into
v55from
take-udf-fixes

Conversation

@masonh22

Copy link
Copy Markdown
  • Closes #.

Several aggregate UDFs keep the default implementation of order_sensitivity() but panic when the ORDER BY column is passed in.

This change updates these UDFs to return
AggregateOrderSensitivity::Insensitive so that the ORDER BY columns are ignored.

I added sqllogictests that fail without the fix.

No

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->

- Closes #.

Several aggregate UDFs keep the default implementation of
`order_sensitivity()` but panic when the `ORDER BY` column is passed in.

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.

Please explain the problem you are trying to solve in terms of the
user-visible
behavior, rather than the implementation.

For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of
the
implementation. "COUNT(DISTINCT) returns wrong results when the column
contains
nulls" is the user-visible problem.
-->

This change updates these UDFs to return
`AggregateOrderSensitivity::Insensitive` so that the `ORDER BY` columns
are ignored.

<!--
There is no need to duplicate the description in the issue here, but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

I added sqllogictests that fail without the fix.

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

Briefly describe how this PR is tested, and point to the specific tests
you added. For example: 'This new feature is covered by the
`sqllogictest` cases added in `foo.slt`'.

If this PR does not add tests, explain why. For example, if the change
is already covered by existing tests, please mention it.

You should also check the `codecov` bot reply on this PR to confirm the
changed code is exercised.
-->

No

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.

If there are any breaking changes to public APIs, please add the `api
change` label.
-->
@masonh22
masonh22 merged commit 6f56664 into v55 Sep 28, 2026
12 checks passed
@masonh22
masonh22 deleted the take-udf-fixes branch September 28, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants