Repository navigation
Df54 apply expressions - #433
Merged
Merged
Conversation
mpurins-coralogix
approved these changes
Sep 6, 2026
|
Should we backport the one from 55? |
Collaborator
Author
I tried to do this first but there were a ton of conflicts. This is effectively the same though. This change was first merged upstream and then reverted and then reapplied. AFAICT there were not changes to the core implementation but the various merge conflicts when it was reapplied made cherry-picking it from the 55 branch much more painful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CX-51808
Upstream DataFusion added an
ExecutionPlan::apply_expressionsto allow visiting allPhsyicalExprs in anExecutionPlan. This was reverted prior to the 54.0.0 release because of concerns about breaking changes (see apache@2a19282).This PR reverts the revert commit since we need
apply_expressionsto make scalar subqueries work with distributed execution.The
apply_expressionschange was later merged back upstream so this commit can be dropped during the DF 55 upgrade.