Repository navigation
Commit a79a694
fix: drop build rows with a dictionary NULL key in null-aware anti joins (apache#26578)
## Which issue does this PR close?
- Closes apache#26568.
## Rationale for this change
`x NOT IN (subquery)` keeps a build row whose key is a dictionary entry
pointing at a NULL value. `NULL NOT IN (5, 6)` is UNKNOWN, so the row
should be dropped, as it is when the key is a physical NULL.
## What changes are included in this PR?
The final step of the uncorrelated null-aware `LeftAnti` join now checks
the logical nulls of the build key instead of `is_null`. They are
computed once with the build side, reusing what apache#25693 added for
`LeftMark`, so the field and its getter are renamed to
`null_aware_build_key_nulls`.
## What is the testing strategy for this PR?
New `test_null_aware_left_anti_build_logical_null` with the case from
the issue. It fails without the fix.
## Are there any user-facing changes?
No.
Co-authored-by: Alejandro Borrego <[email protected]>
Co-authored-by: Jay Zhan <[email protected]>1 parent ebf4858 commit a79a694
2 files changed
Lines changed: 91 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
357 | 357 | | |
358 | 358 | | |
359 | 359 | | |
360 | | - | |
| 360 | + | |
| 361 | + | |
361 | 362 | | |
362 | 363 | | |
363 | 364 | | |
364 | | - | |
| 365 | + | |
365 | 366 | | |
366 | 367 | | |
367 | 368 | | |
| |||
438 | 439 | | |
439 | 440 | | |
440 | 441 | | |
441 | | - | |
442 | | - | |
| 442 | + | |
| 443 | + | |
443 | 444 | | |
444 | 445 | | |
445 | 446 | | |
| |||
3647 | 3648 | | |
3648 | 3649 | | |
3649 | 3650 | | |
3650 | | - | |
| 3651 | + | |
3651 | 3652 | | |
3652 | | - | |
3653 | | - | |
3654 | | - | |
3655 | | - | |
| 3653 | + | |
| 3654 | + | |
| 3655 | + | |
| 3656 | + | |
| 3657 | + | |
| 3658 | + | |
| 3659 | + | |
| 3660 | + | |
| 3661 | + | |
3656 | 3662 | | |
3657 | 3663 | | |
3658 | 3664 | | |
3659 | 3665 | | |
3660 | 3666 | | |
3661 | 3667 | | |
3662 | 3668 | | |
3663 | | - | |
| 3669 | + | |
3664 | 3670 | | |
3665 | 3671 | | |
3666 | 3672 | | |
| |||
3692 | 3698 | | |
3693 | 3699 | | |
3694 | 3700 | | |
3695 | | - | |
| 3701 | + | |
3696 | 3702 | | |
3697 | 3703 | | |
3698 | 3704 | | |
| |||
10549 | 10555 | | |
10550 | 10556 | | |
10551 | 10557 | | |
| 10558 | + | |
| 10559 | + | |
| 10560 | + | |
| 10561 | + | |
| 10562 | + | |
| 10563 | + | |
| 10564 | + | |
| 10565 | + | |
| 10566 | + | |
| 10567 | + | |
| 10568 | + | |
| 10569 | + | |
| 10570 | + | |
| 10571 | + | |
| 10572 | + | |
| 10573 | + | |
| 10574 | + | |
| 10575 | + | |
| 10576 | + | |
| 10577 | + | |
| 10578 | + | |
| 10579 | + | |
| 10580 | + | |
| 10581 | + | |
| 10582 | + | |
| 10583 | + | |
| 10584 | + | |
| 10585 | + | |
| 10586 | + | |
| 10587 | + | |
| 10588 | + | |
| 10589 | + | |
| 10590 | + | |
| 10591 | + | |
| 10592 | + | |
| 10593 | + | |
| 10594 | + | |
| 10595 | + | |
| 10596 | + | |
| 10597 | + | |
| 10598 | + | |
| 10599 | + | |
| 10600 | + | |
| 10601 | + | |
| 10602 | + | |
| 10603 | + | |
| 10604 | + | |
| 10605 | + | |
| 10606 | + | |
| 10607 | + | |
| 10608 | + | |
| 10609 | + | |
| 10610 | + | |
| 10611 | + | |
| 10612 | + | |
| 10613 | + | |
| 10614 | + | |
| 10615 | + | |
| 10616 | + | |
| 10617 | + | |
| 10618 | + | |
| 10619 | + | |
| 10620 | + | |
| 10621 | + | |
| 10622 | + | |
| 10623 | + | |
| 10624 | + | |
10552 | 10625 | | |
10553 | 10626 | | |
10554 | 10627 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1379 | 1379 | | |
1380 | 1380 | | |
1381 | 1381 | | |
1382 | | - | |
1383 | | - | |
| 1382 | + | |
| 1383 | + | |
| 1384 | + | |
| 1385 | + | |
| 1386 | + | |
1384 | 1387 | | |
1385 | 1388 | | |
1386 | 1389 | | |
1387 | | - | |
| 1390 | + | |
1388 | 1391 | | |
1389 | 1392 | | |
1390 | 1393 | | |
| |||
1406 | 1409 | | |
1407 | 1410 | | |
1408 | 1411 | | |
1409 | | - | |
| 1412 | + | |
1410 | 1413 | | |
1411 | 1414 | | |
1412 | 1415 | | |
| |||
0 commit comments