Hi @cophilot , I tried of solving #20 , in this PR, the approach I followed is fairly straight forward (explained in the PR), but I think is good enough to get the job done. Please go through the approach, if it fits. Also if you want me to include any tests to test this functionality , please let me know, I will include that.
Thanks

Hi @cophilot , I tried of solving #20 , in this PR, the approach I followed is fairly straight forward (explained in the PR), but I think is good enough to get the job done. Please go through the approach, if it fits. Also if you want me to include any tests to test this functionality , please let me know, I will include that. Thanks

Hi @RounakJoshi09
As we already discussed in #20 I don`t like that the files get written out and then cleaned up afterwards. I want that no files are getting generated, at any point, if not all files could be generated. Therefore I would suggest to first loop over the files and check if all files would theoretically be generated (without actually generating them!) and if that is successful for all files then all will be generated. When even one check fails then no file should be generated.

Also a test for that would be highly appreciated.

If you need any help or more information on this let me know :)

@RounakJoshi09 If you are finished with the implementation, please set the PR back to ready.

Hi @cophilot , I have changed the approach , according to which, I am storing all the files to be generated in vector, and when the program confirms that all the files can be generated then I am generating them by iterating through the array. Please check this once and let me know what you think about it.
Also I am not able to frame how can I write test case for this particular scenario, a little help for that would be very helpful.
Thanks,

Thanks @RounakJoshi09 ! It already looks pretty good, only one minor refactoring and then its perfect :)

For the test you can edit the tests/command_tests/generate_tests and there you can do something like:

    fs::templates_dir()
        .dir("MyTest")
        .file(".templify.yml").create();
    fs::templates_dir()
        .dir("MyTest")
        .file("test.txt").create();
    fs::templates_dir()
        .dir("MyTest")
        .file("$$name$$.txt").create();

    utils::run_successfully("tpy generate MyTest test1");

    utils::run_fail("tpy generate MyTest test2"); // This should not work because test.txt already exist

    log::contains_line("File ./test.txt already exists."); // check if reason is given to the user

    fs::file("test2.txt").check_not_exist(); // check that the other file was not generated even it would be possible

If you still have issues creating the test case for this then let me know and I will help you.

Thank you for the feedback, @cophilot . I've implemented the suggested changes. I'd like to provide some context for one of the modifications:

To integrate the file generation process within the template handler, I introduced an additional function. This new function initializes the vector for files and subsequently triggers the file generation. The rationale behind this approach is that generate_template_dir is a recursive function. To ensure all files are properly stored without reinitialization, we need to pass the files vector by reference. Consequently, I created a separate function within the template handler that internally invokes generate_template_dir.

Please let me know if you need any further clarification or have additional suggestions.

Hi @RounakJoshi09 Thank you for the fix. I will merge it now and the fix will be released with version 2.0.1 :)

Thanks a lot @cophilot . Can you please assign some new task as well