vine: fix doc typos, code typos, and callback signatures for FuturesExecutor#3836
Merged
dthain merged 2 commits intocooperative-computing-lab:masterfrom May 17, 2024
gpauloski:issue-3835
Merged
vine: fix doc typos, code typos, and callback signatures for FuturesExecutor#3836dthain merged 2 commits intocooperative-computing-lab:masterfrom gpauloski:issue-3835
FuturesExecutor#3836dthain merged 2 commits intocooperative-computing-lab:masterfrom
gpauloski:issue-3835
Conversation
gpauloski
changed the title
FuturesExecutorFuturesExecutor
BarrySlyDelgado
approved these changes
May 14, 2024
Contributor
|
Thanks for noting these issues! a more detailed comment has been posted here: #3835. In short, these changes should fix that mentioned issues (1, 2, 4, 5). Issue 3 will be fixed in a forthcoming PR while 6 may require more thought regarding the implementation of the futures executor along with TaskVine. |
Member
|
@BarrySlyDelgado is this RTM? |
Contributor
|
Yes. |
dthain
approved these changes
May 17, 2024
btovar
pushed a commit
that referenced
this pull request
Jun 14, 2024
…Executor` (#3836) * Fix typos and callback signatures in FuturesExecutor * Fix typos in FuturesExecutor examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Please describe your changes (e.g., what problems they attempt to solve, what results are expected, etc.) Additional motivation and context are welcome.
Please also mention relevant issues and pull requests as appropriate.
This PR fixes four of the six issues discussed in #3835 (specifically, 1, 2, 4, and 5).
Post-change actions
Put an 'x' in the boxes that describe post-change actions that you have done.
The more 'x' ticked, the faster your changes are accepted by maintainers.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.Additional comments
This section is dedicated to changes that are ambitious or complex and require substantial discussions. Feel free to start the ball rolling.