Skip to content

Change pydoc search.#2211

Closed
tkameyama wants to merge 1 commit intocooperative-computing-lab:masterfrom
tkameyama:bugfix/pydoc
Closed

Change pydoc search.#2211
tkameyama wants to merge 1 commit intocooperative-computing-lab:masterfrom
tkameyama:bugfix/pydoc

Conversation

@tkameyama
Copy link
Copy Markdown

pydoc is faiied when wrong PYTHONHOME environment variable is found.

$ PYTHONHOME=/tmp pydoc -w umbrella
ImportError: No module named site

This PR search pydoc in python install directory (expected to match PYTHONHOME ).

@btovar
Copy link
Copy Markdown
Member

btovar commented Nov 27, 2019

Thanks for the pr!

However, if PYTHONHOME has an invalid value, none of the python scripts would work anyway. Since umbrella and its documentation are optional, I'm thinking of simply skipping them with a warning if the python environment is invalid.

@tkameyama
Copy link
Copy Markdown
Author

Thanks for the pr!

However, if PYTHONHOME has an invalid value, none of the python scripts would work anyway.

I am assuming the following situation:

  • Multiple pythons (For example python2 and pyton3) are installed on build host.
  • PYTHONHOME environment variable is set for the python3.
  • The user specify $PYTHONHOME/bin/python3 by configure option.
  • configure detect pydoc for python2.

@btovar
Copy link
Copy Markdown
Member

btovar commented Dec 4, 2019

@tkameyama, could you confirm whether pr #2217 does what you need?

We are in the process of changing how the configure script detect the python environment, to make sure, among other things, that the correct pydoc is found.

@tkameyama
Copy link
Copy Markdown
Author

@tkameyama, could you confirm whether pr #2217 does what you need?

Yes.

We are in the process of changing how the configure script detect the python environment, to make sure, among other things, that the correct pydoc is found.

I hope it.

@btovar
Copy link
Copy Markdown
Member

btovar commented Mar 25, 2020

This has been resolved by e6de50b and the latest ./configure.

@btovar btovar closed this Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants