Skip to content

Comments

Remove unused import from post-generate hook script example#1795

Merged
jensens merged 3 commits intocookiecutter:mainfrom
KAZYPinkSaurus:main
Jun 12, 2023
Merged

Remove unused import from post-generate hook script example#1795
jensens merged 3 commits intocookiecutter:mainfrom
KAZYPinkSaurus:main

Conversation

@KAZYPinkSaurus
Copy link
Contributor

Thank you!

@KAZYPinkSaurus KAZYPinkSaurus changed the title Remove unused import from post-generate hook script example. Remove unused import from post-generate hook script example Nov 15, 2022
Copy link
Member

@kurtmckee kurtmckee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pydanny @ssbarnea @jensens Please merge this PR.

It increases the readability of the hook example by removing an unused import.

@jensens jensens added the patch Little bugfix, typo fix, etc. When only patch version should be updated label Jun 12, 2023
@kurtmckee
Copy link
Member

@jensens It looks like merging PRs is following a policy that introduces significant delays. For example, this PR has had main merged into it twice, and CI will have run 3 times for just this one PR.

Is this something that's getting enforced by settings in the GitHub repo? If so, is it possible to disable the requirements so PRs can merge as soon as CI passes and the PR has been reviewed?

@jensens jensens merged commit 7df17c3 into cookiecutter:main Jun 12, 2023
@KAZYPinkSaurus
Copy link
Contributor Author

thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Little bugfix, typo fix, etc. When only patch version should be updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants