Skip to content

Properly handle missing optional fields.#327

Merged
binh-dam-ibigroup merged 7 commits intodevfrom
fix-ref-integrity-for-optional-fields
Sep 29, 2021
Merged

Properly handle missing optional fields.#327
binh-dam-ibigroup merged 7 commits intodevfrom
fix-ref-integrity-for-optional-fields

Conversation

@binh-dam-ibigroup
Copy link
Copy Markdown
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup commented Sep 28, 2021

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • [na] The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR partially addresses ibi-group/datatools-server#425 where, as a result of upgrading to gtfs-lib version 7.0.0, referential integrity errors are thrown with the fare_rules.txt table where optional columns are missing in the GTFS imported archive.

@binh-dam-ibigroup binh-dam-ibigroup changed the title fix(LineContext): Add (failing) test for querying missing fields. Properly handle missing optional fields. Sep 28, 2021
@br648
Copy link
Copy Markdown
Collaborator

br648 commented Sep 28, 2021

See: #328

@binh-dam-ibigroup binh-dam-ibigroup marked this pull request as ready for review September 28, 2021 17:07
Copy link
Copy Markdown
Collaborator

@br648 br648 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Approved.

@br648 br648 assigned binh-dam-ibigroup and unassigned br648 Sep 29, 2021
@binh-dam-ibigroup binh-dam-ibigroup merged commit 80c85c4 into dev Sep 29, 2021
@binh-dam-ibigroup binh-dam-ibigroup deleted the fix-ref-integrity-for-optional-fields branch September 29, 2021 12:54
@binh-dam-ibigroup binh-dam-ibigroup mentioned this pull request Sep 29, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants