Merged
Conversation
gtfs-lib new major version release
br648
requested changes
Sep 28, 2021
Collaborator
br648
left a comment
br648
left a comment
There was a problem hiding this comment.
Just one change recommended to the unit test.
binh-dam-ibigroup
approved these changes
Sep 28, 2021
Collaborator
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Approving pending figuring out a resolution to the build error.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
Closes #325 and adds unit tests to prevent a similar issue from happening again. The test is structured in a way that future GTFS Flex features can also be tested in a similar way (with a new feed that is small enough new features can be added to it)