Skip to content

Remove unneeded arguments from ConditionalRequirements classes#320

Merged
br648 merged 1 commit intogtfs-spec-updatesfrom
gtfs-spec-updates-eas
May 19, 2021
Merged

Remove unneeded arguments from ConditionalRequirements classes#320
br648 merged 1 commit intogtfs-spec-updatesfrom
gtfs-spec-updates-eas

Conversation

@evansiroky
Copy link
Copy Markdown
Contributor

@evansiroky evansiroky commented May 18, 2021 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR refactors the ConditionRequirement class further by moving subclass-specific fields to those subclasses. It also fixes what seems to be an error in the logic within the FieldNotEmptyAndMatchesValueCheck check method.

@evansiroky evansiroky mentioned this pull request May 18, 2021
Merged
5 tasks
@br648
Copy link
Copy Markdown
Collaborator

br648 commented May 19, 2021

Thanks. On review I don't think the dependentFieldCheck is needed now that we have specific classes for each conditional check.

@br648 br648 merged commit b8be2e1 into gtfs-spec-updates May 19, 2021
@landonreed landonreed deleted the gtfs-spec-updates-eas branch June 21, 2021 16:23
@landonreed landonreed mentioned this pull request Aug 16, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@br648 br648

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@evansiroky @br648