-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UTF-8 characters have the wrong encoding when using OMEMO #1187
Comments
This happens only with OMEMO enabled. |
I managed to fix it by modifying the arrayBuffer <-> string methods:
Now it seems to work for me. I guess you need to implement it with a API which is supported by more/older browsers as well. |
When I look at the libsignal docs: Does the api even need conversion?
|
Thanks, unfortunately TextDecoder/TextEncoder is not implemented in Edge. |
We don't just encrypt with libsignal, the browser's builtin crypto is used to encrypt the actual message and then they keys that were generated to do that are encrypted by libsignal. |
Fixed in master, will be included in the next release. |
With rev 45643d5 I am not able to write encrypted messages. Receiving client running "Conversations" just does not show any new message. Receiving Client running Pidgin with Lurch is showing: "There was an error decrypting an OMEMO message addressed to this device. See the debug log for details." Lurch debug log shows "failed to decrypt payload (-10020)" Reverted to 4.0.0 to make basic sending work again Edit: Did not do any bisecting. Any change between Tag 4.0.0 and HEAD can be the culprit, not necessarily the change to fix this bug |
@sleeksorrow thanks for reporting, I'll look into it |
I did a |
In converse.js I see UTF-8 characters (e.g.
ü
) from apps like Conversations or gajim as two bytes likeü
and in Conversations I see�
for such characters sent via Conversations.The page includes:
The text was updated successfully, but these errors were encountered: