refactor(cli): port cli to typescript#978
Closed
armano2 wants to merge 23 commits intoconventional-changelog:masterfrom
Closed
refactor(cli): port cli to typescript#978armano2 wants to merge 23 commits intoconventional-changelog:masterfrom
armano2 wants to merge 23 commits intoconventional-changelog:masterfrom
Conversation
6ddc1a1 to
00304bc
Compare
armano2
commented
Feb 8, 2020
| export interface QualifiedConfig { | ||
| extends: string[]; | ||
| formatter: unknown; | ||
| rules: Partial<QualifiedRules>; |
Contributor
Author
There was a problem hiding this comment.
QualifiedRules is already Partial
Contributor
Author
|
seems that linux build is failing due to: |
f02aacb to
5d6fb5e
Compare
Contributor
Author
|
yargs has built in feature of producing help: |
marionebl
reviewed
Feb 8, 2020
marionebl
reviewed
Feb 8, 2020
Contributor
Author
|
for now i'v done simple migration, but we could move most of args validations to yargs |
armano2
commented
Feb 9, 2020
armano2
commented
Feb 9, 2020
armano2
commented
Feb 9, 2020
armano2
commented
Feb 9, 2020
armano2
commented
Feb 9, 2020
4488113 to
6fea4cf
Compare
Contributor
Author
|
it seems that you did some mistakes while doing rebase |
armano2
commented
Feb 9, 2020
armano2
commented
Feb 9, 2020
armano2
commented
Feb 9, 2020
e869e16 to
712f4cd
Compare
armano2
commented
Feb 11, 2020
1 task
escapedcat
approved these changes
Feb 15, 2020
Member
|
@armano2 thanks so much for all your efforts! ❤️ |
This was referenced Jun 27, 2020
Member
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #659
At first i wanted to just migrate it without refactoring, but as [email protected] has horrible type and v6 (current) is just a wrapper for yargs (with horrible types) than we can use yargs directly to reduce complexity.
while reviewing i do recommend to disable whitespaces as diff is getting way more readable
https://github.com/conventional-changelog/commitlint/pull/978/files?utf8=✓&diff=split&w=1
Motivation and Context
Ported cli to typescript as part of #659
How Has This Been Tested?Types of changes
Checklist: