refactor(lint): port lint to typescript#908
Merged
Conversation
7 tasks
marionebl
force-pushed
the
refactor/lint-to-ts
branch
from
5192547 to
09803ea
Compare
marionebl
force-pushed
the
refactor/lint-to-ts
branch
from
09803ea to
6169610
Compare
armano2
reviewed
Feb 5, 2020
| "globby": "11.0.0" | ||
| }, | ||
| "dependencies": { | ||
| "@commitlint/types": "^8.3.4", |
Contributor
There was a problem hiding this comment.
@commitlint/types can/should be in devDependencies as it does not contain any runtime code
Contributor
There was a problem hiding this comment.
In our case it does - we expose som enums, which emit runtime code, e.g.
// @commitlint/types/lib/load.js
"use strict";
exports.__esModule = true;
var RuleSeverity;
(function (RuleSeverity) {
RuleSeverity[RuleSeverity["Disabled"] = 0] = "Disabled";
RuleSeverity[RuleSeverity["Warning"] = 1] = "Warning";
RuleSeverity[RuleSeverity["Error"] = 2] = "Error";
})(RuleSeverity = exports.RuleSeverity || (exports.RuleSeverity = {}));
var RuleConfigQuality;
(function (RuleConfigQuality) {
RuleConfigQuality[RuleConfigQuality["User"] = 0] = "User";
RuleConfigQuality[RuleConfigQuality["Qualified"] = 1] = "Qualified";
})(RuleConfigQuality = exports.RuleConfigQuality || (exports.RuleConfigQuality = {}));
//# sourceMappingURL=load.js.map
armano2
reviewed
Feb 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Port of
@commtlint/lintto TypeScript, part of #659Motivation and ContextUsage examplesHow Has This Been Tested?Types of changes
Checklist: