feat(rules): add subject-matches & header-matches rules#819
Closed
sepehr wants to merge 2 commits intoconventional-changelog:masterfrom
sepehr:header-subject-matches
Closed
feat(rules): add subject-matches & header-matches rules#819sepehr wants to merge 2 commits intoconventional-changelog:masterfrom sepehr:header-subject-matches
sepehr wants to merge 2 commits intoconventional-changelog:masterfrom
sepehr:header-subject-matches
Conversation
Member
|
@marionebl what do you think? I think it definitely helps users give more customization, I'm not sure if it's "in the same vision" of the other rules. Like are we giving to much customization? Again, I don't think so but this one might be better if you decide 😄 Thanks for your work @sepehr ❤️ it looks solid! |
7 tasks
7 tasks
Member
|
@sepehr sorry, this got lost. Would you mind rebasing it? Then we could merge it. |
Author
|
No worries @escapedcat. I'll give it a look asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This brings two additional rules to the table;
header-matchesandsubject-matcheswhich are given a string regex to match against the header and subject respectively.Motivation and Context
The motivation behind this is more about ease-of-use when granular customization is needed. While I'm sure, the same goal can be achieved using custom parsers, I found myself not wanting to redefine headers and subjects in parser presets. I just needed more customization power.
While this might suit a plugin, I felt like it could also be a good fit for core rules as it opens up endless possibilities for customization.
Usage examples
How Has This Been Tested?
Added new test suites.
Types of changes
Checklist