feat(rules): add regex support for [subject|header]-full-stop rules#818
Closed
sepehr wants to merge 1 commit intoconventional-changelog:masterfrom
sepehr:full-stop-regex
Closed
feat(rules): add regex support for [subject|header]-full-stop rules#818sepehr wants to merge 1 commit intoconventional-changelog:masterfrom sepehr:full-stop-regex
sepehr wants to merge 1 commit intoconventional-changelog:masterfrom
sepehr:full-stop-regex
Conversation
byCedric
approved these changes
Oct 5, 2019
Member
byCedric
left a comment
There was a problem hiding this comment.
Awesome, I like this feature ❤️ @marionebl what do you think?
7 tasks
Member
|
I think this completely got lost during busy times. |
Author
|
Thanks for the update @escapedcat. Will surely do. Since I got your attention, do you think #819 might also worth rebase and Typescript port? |
Member
Member
|
@sepehr closing this for now. Please reopen if you find time for a rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This allows usage of string regular expressions as
valueforsubject-full-stopandheader-full-stoprules.Motivation and Context
We, internally, allow a range of stops. The current rule, however, allows providing one stop character which is restrictive, at least, in our use-case.
Yet, I'm not sure if it's a better fit for a plugin or the core.
Usage examples
How Has This Been Tested?
By adding new test cases.
Types of changes
Checklist