Skip to content

refactor: port to-lines to ts#677

Merged
marionebl merged 3 commits intoconventional-changelog:masterfrom
bendtherules:build-to-lines-ts-port
Jun 3, 2019
Merged

refactor: port to-lines to ts#677
marionebl merged 3 commits intoconventional-changelog:masterfrom
bendtherules:build-to-lines-ts-port

Conversation

@bendtherules
Copy link
Copy Markdown
Contributor

@bendtherules bendtherules commented Jun 2, 2019

Fixes part of #659. This ports @commitlint/to-lines src and tests to typescript.

Changes made:

  1. Remove ava config, dependencies and scripts from package.json
  2. Add typescript and jest config, dependencies and scripts instead
  3. Port to-lines/* source and test files to ts

How Has This Been Tested?

npm run test inside @commitlint/to-lines

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bendtherules
Copy link
Copy Markdown
Contributor Author

bendtherules commented Jun 3, 2019

There seems to be some issue with CI checks ??

@marionebl
Copy link
Copy Markdown
Contributor

marionebl commented Jun 3, 2019

There seems to be some issue with CI checks ??

Yes, I recently reconfigured CircleCI now there seems to be some desync with the repo settings...

@marionebl marionebl merged commit c102d2f into conventional-changelog:master Jun 3, 2019
@marionebl
Copy link
Copy Markdown
Contributor

marionebl commented Jun 3, 2019

Thanks again :)

@marionebl marionebl mentioned this pull request Jun 3, 2019
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bendtherules @marionebl