fix slash in scope #291#529
Conversation
|
@marionebl |
|
I like the tests-first approach! 👍 I've also dug a bit deeper into Lodash A solution that comes to mind is trying to split the branch name based on either one of the dashes ( |
|
I created the solution I explained earlier, wanted to see if it could work. And well, all tests are in the green. 😄 Replace in file This expects either a |
|
Mind blown. You want to add that code? Added you as a collaborator on my fork. Or you branch out from this one. |
|
Haha, nice 😄 I've added the code! Is this something that we can use or do you know other solutions? |
Tried to narrow this down.
Description
Using this scope
Modules\Graphwith thepascal-caserule fails.In
@commitlint/rules/src/scope-case.js:const r = ensure.case(scope, check.case);this returns false for such case.First I only try to add a test-case which would be suitable for this situation. If this is correct we could chech where a fix in
case.jscoudl be implemented.Currently thsi test fails: