fix(cli): avoid linebreak in empty input#523
Merged
marionebl merged 1 commit intoconventional-changelog:masterfrom Jan 27, 2019
Merged
fix(cli): avoid linebreak in empty input#523marionebl merged 1 commit intoconventional-changelog:masterfrom
marionebl merged 1 commit intoconventional-changelog:masterfrom
Conversation
escapedcat
commented
Dec 17, 2018
escapedcat
force-pushed
the
fix/511_empty-message-output
branch
from
6bd2de8 to
b81c895
Compare
escapedcat
commented
Dec 19, 2018
escapedcat
force-pushed
the
fix/511_empty-message-output
branch
from
b81c895 to
d60b3a0
Compare
marionebl
approved these changes
Jan 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed we can trim the empty input to invalidate an input which per default comes as
\n.Motivation and Context
#511
How Has This Been Tested?
I need help here. We have this test but I'm not sure what is being tested here. It worked before and still works...
Types of changes
Checklist: