Skip to content

feat: warn on empty config#491

Merged
marionebl merged 3 commits intoconventional-changelog:masterfrom
escapedcat:feat/107_warn-on-empty-config
Nov 30, 2018
Merged

feat: warn on empty config#491
marionebl merged 3 commits intoconventional-changelog:masterfrom
escapedcat:feat/107_warn-on-empty-config

Conversation

@escapedcat
Copy link
Copy Markdown
Member

@escapedcat escapedcat commented Nov 18, 2018

https://github.com/marionebl/commitlint/issues/107

Description

Push empty rules error to commitlint results if no rules are found.

How Has This Been Tested?

See: https://github.com/marionebl/commitlint/compare/master...escapedcat:feat/107_warn-on-empty-config?expand=1#diff-9ab1790ed00b7ca8fb5c7def7e9d2641R49

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat
Copy link
Copy Markdown
Member Author

escapedcat commented Nov 18, 2018 

  src/library/get-prompt.js:18:1
  ⚠  18:1  Function getPrompt has a complexity of 21.  complexity

  1 warning

Linting fails because of this. I don't think this is caused by my changes.

@escapedcat escapedcat requested a review from marionebl November 25, 2018 14:39
@escapedcat
Copy link
Copy Markdown
Member Author

escapedcat commented Nov 25, 2018 

@commitlint/cli:   × should work with husky via commitlint -e %GIT_PARAMS% Error: Test was expected to fail, but succeeded, you should stop marking the test as failing

What is causing this? I already mentioned it in the slack channel.

@marionebl
Copy link
Copy Markdown
Contributor

marionebl commented Nov 25, 2018 

@commitlint/cli:   × should work with husky via commitlint -e %GIT_PARAMS% Error: Test was  expected to fail, but succeeded, you should stop marking the test as failing

What is causing this? I already mentioned it in the slack channel.

Let's skip the failing test for now. We'll remove the $GIT_PARAMS handling for good when this is in master

@marionebl marionebl changed the title Feat/107 warn on empty config feat: warn on empty config Nov 25, 2018
marionebl
marionebl approved these changes Nov 25, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@marionebl marionebl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the failing test this is ready to merge. Let's skip the test as discussed.

@byCedric
Copy link
Copy Markdown
Member

byCedric commented Nov 26, 2018

Oh my bad, I created two separate (both different) approaches to fix the failing test here.

@marionebl marionebl force-pushed the feat/107_warn-on-empty-config branch from 48ac391 to d3f4f03 Compare November 30, 2018 03:50
@marionebl marionebl force-pushed the feat/107_warn-on-empty-config branch from 91e1f03 to fbbf07b Compare November 30, 2018 04:47
@marionebl marionebl merged commit b6bd36e into conventional-changelog:master Nov 30, 2018
@escapedcat escapedcat mentioned this pull request Dec 13, 2018
Closed
4 tasks
@escapedcat escapedcat deleted the feat/107_warn-on-empty-config branch September 11, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@marionebl marionebl marionebl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@escapedcat @marionebl @byCedric