Revert "fix: update dependency global-directory to v5 (#4671)"#4677
Merged
escapedcat merged 1 commit intomasterfrom Mar 31, 2026
Merged
Revert "fix: update dependency global-directory to v5 (#4671)"#4677escapedcat merged 1 commit intomasterfrom
escapedcat merged 1 commit intomasterfrom
Conversation
This reverts commit a300d32.
Review Summary by QodoRevert global-directory v5 to restore Node 18 compatibility
WalkthroughsDescription• Revert global-directory to v4 for Node 18 compatibility • v5 requires Node 20+, breaking project's Node 18 support • Restores compatibility until project drops Node 18 Diagramflowchart LR
A["global-directory v5<br/>Node 20+ required"] -- "revert to" --> B["global-directory v4<br/>Node 18+ compatible"]
File Changes1. @commitlint/resolve-extends/package.json
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the global-directory dependency upgrade (v5 → v4) to preserve Node 18 compatibility across the project, aligning dependency engine requirements with the repository’s stated support for Node >=18.
Changes:
- Downgrade
global-directoryto^4.0.1in@commitlint/resolve-extends. - Update
yarn.lockaccordingly, including reverting the transitiveinidependency from6.0.0to4.1.1. - Remove lockfile entries associated with
global-directory@^5.0.0/[email protected].
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
@commitlint/resolve-extends/package.json |
Reverts global-directory version to restore Node 18 compatibility. |
yarn.lock |
Locks [email protected] and adjusts transitive ini dependency to match. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Mar 31, 2026
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert global-directory v5 to restore Node 18 compatibility
global-directory v5 declares engines: node>=20, but this project
supports node>=18. The API is unchanged so nothing broke yet, but
a future patch release could use Node 20+ APIs and break Node 18
users without warning. Reverts to v4 until the project drops Node 18.