Skip to content

chore: deps and CI improvements #4660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
escapedcat merged 9 commits into from
Mar 16, 2026
Merged

chore: deps and CI improvements #4660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
eca08ee
chore: deps
escapedcat Mar 16, 2026
4a2bcdf
fix: vitest 4.1 compatibility
escapedcat Mar 16, 2026
261c2e4
chore: deps
escapedcat Mar 16, 2026
01d9179
chore: downgrade vitest to v3 for Node 18 support
escapedcat Mar 16, 2026
159abb5
chore: use lts/* for codeQuality CI job
escapedcat Mar 16, 2026
67a0b27
chore: test on Node 18, 20, 22, and 24
escapedcat Mar 16, 2026
7fd04b8
chore: test on Node 18, 20, and 22
escapedcat Mar 16, 2026
fe49c4f
docs: remove nvm and asdf references, use mise only
escapedcat Mar 16, 2026
04fb7a3
chore: pin vitest to ~4.0.18 to maintain Node 18 support
escapedcat Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,10 @@ For more information refer to [vitepress documentation](https://vitepress.dev).

```sh
npm login
nvm use (if you have nvm installed)
mise install
```

- [nvm](https://github.com/nvm-sh/nvm)
- [asdf](https://asdf-vm.com/) is supported as well
- [mise](https://mise.jdx.dev/)

```sh
yarn clean
Expand All @@ -136,7 +135,7 @@ has not been published yet.

```sh
npm login
nvm use (if you have nvm installed)
mise install
```

```sh
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: CI
on:
push:
branches:
- "**"
- master
Copy link
Copy Markdown
Contributor

@knocte knocte Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@escapedcat I disagree with this

Copy link
Copy Markdown
Member Author

@escapedcat escapedcat Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please elaborate. I wanted to get rid of all the checks running two times.

Copy link
Copy Markdown
Contributor

@knocte knocte Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about you check git blame so I don't need to elaborate two times :)

Copy link
Copy Markdown
Member Author

@escapedcat escapedcat Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gosh, wait

Copy link
Copy Markdown
Member Author

@escapedcat escapedcat Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4665

This avoids duplication by cancelling, wdyt

Copy link
Copy Markdown
Contributor

@knocte knocte Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then CI looks 50% broken, I guess because GitHub considers cancelled jobs as failure.

Copy link
Copy Markdown
Member Author

@escapedcat escapedcat Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Researched how other popular OSS projects handle this. Adjusted it. Please check

pull_request:
types: [opened, synchronize]

Expand All @@ -18,7 +18,9 @@ jobs:
strategy:
matrix:
os: [ubuntu-22.04, ubuntu-24.04, windows-2022, windows-2025]
node: [18, 20]
# Node versions match Ubuntu LTS defaults:
# 18 = Ubuntu 24.04, 20 = Ubuntu 25.x, 22 = Ubuntu 26.04
node: [18, 20, 22]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v6
Expand Down Expand Up @@ -46,7 +48,7 @@ jobs:

- uses: actions/setup-node@v6
with:
node-version: 20
node-version: lts/*
cache: yarn

- name: Install dependencies
Expand Down
2 changes: 2 additions & 0 deletions .mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[tools]
node = "18"
1 change: 0 additions & 1 deletion .nvmrc
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion .tool-versions
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion @packages/test-environment/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"dependencies": {
"@types/tmp": "^0.2.5",
"tmp": "^0.2.1",
"vitest": "^4.0.18"
"vitest": "~4.0.18"
},
"gitHead": "71f0194f33943954a8dac1c458be47e5049717cd"
}
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"@swc/core": "^1.15.18",
"@typescript-eslint/eslint-plugin": "^8.56.1",
"@typescript-eslint/parser": "^8.56.1",
"@vitest/coverage-istanbul": "^4.0.18",
"@vitest/coverage-istanbul": "~4.0.18",
"@vitest/eslint-plugin": "^1.3.4",
"cross-env": "^7.0.3",
"eslint": "^10.0.2",
Expand All @@ -97,12 +97,12 @@
"globals": "^16.0.0",
"husky": "^9.1.5",
"lerna": "^8.2.0",
"lint-staged": "16.3.3",
"lint-staged": "16.4.0",
"prettier": "^3.5.3",
"typescript": "^5.2.2",
"vitepress": "^1.3.4",
"vitepress-plugin-tabs": "^0.8.0",
"vitest": "^4.0.18",
"vitest": "~4.0.18",
"vue": "^3.5.29"
}
}
613 changes: 290 additions & 323 deletions yarn.lock
View file
Open in desktop

Large diffs are not rendered by default.