chore: deps and CI improvements#4660
Merged
escapedcat merged 9 commits intomasterfrom Mar 16, 2026
Merged
Conversation
- Exclude JSON files from coverage to prevent Babel parse errors - Update vitest/environments imports to vitest/runtime Co-Authored-By: Claude Opus 4.5 <[email protected]>
Review Summary by QodoUpdate vitest 4.1 compatibility and coverage configuration
WalkthroughsDescription• Update vitest imports from vitest/environments to vitest/runtime • Exclude JSON files from coverage to prevent Babel parse errors • Ensure compatibility with vitest 4.1 Diagramflowchart LR
A["vitest 4.1 upgrade"] --> B["Update imports"]
A --> C["Coverage configuration"]
B --> D["vitest/runtime"]
C --> E["Exclude JSON files"]
File Changes1. @packages/test-environment/src/test-environment.ts
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
- Downgrade vitest and @vitest/coverage-istanbul from ^4.0.18 to ^3.2.4 - Revert vitest.config.ts v4-specific changes - Revert test-environment imports to vitest v3 format - Replace .tool-versions and .nvmrc with .mise.toml - Update CONTRIBUTING.md to reference mise Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Node versions match Ubuntu LTS defaults: - 18 = Ubuntu 24.04 - 20 = Ubuntu 25.x - 22 = Ubuntu 26.04 Co-Authored-By: Claude Opus 4.5 <[email protected]>
escapedcat
force-pushed
the
chore/deps-260316
branch
from
d6c06e1 to
7fd04b8
Compare
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Using tilde (~) pins to 4.0.x, avoiding 4.1.x which introduced rolldown and dropped Node 18 support. Co-Authored-By: Claude Opus 4.5 <[email protected]>
escapedcat
force-pushed
the
chore/deps-260316
branch
from
4e8df63 to
04fb7a3
Compare
knocte
reviewed
Mar 17, 2026
| push: | ||
| branches: | ||
| - "**" | ||
| - master |
Member
Author
There was a problem hiding this comment.
Please elaborate. I wanted to get rid of all the checks running two times.
Contributor
There was a problem hiding this comment.
how about you check git blame so I don't need to elaborate two times :)
Member
Author
There was a problem hiding this comment.
This avoids duplication by cancelling, wdyt
Contributor
There was a problem hiding this comment.
But then CI looks 50% broken, I guess because GitHub considers cancelled jobs as failure.
Member
Author
There was a problem hiding this comment.
Researched how other popular OSS projects handle this. Adjusted it. Please check
This was referenced Mar 31, 2026
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Downgrade vitest to v3 to maintain Node 18 compatibilityStick with latest possible v4.nvmrc/.tool-versionsto.mise.tomlfor version management, and 24lts/*for codeQuality CI job