Skip to content

fix(is-ignored): strip CI skip markers from release commits #4637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
escapedcat merged 2 commits into from
Mar 12, 2026
Merged

fix(is-ignored): strip CI skip markers from release commits #4637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65233a7
fix(is-ignored): strip CI skip markers from release commits
Br1an67 Mar 6, 2026
6917bde
trigger ci
escapedcat Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion @commitlint/is-ignored/src/defaults.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ const isSemver = (c: string): boolean => {
return false;
}

const stripped = firstLine.replace(/^chore(\([^)]+\))?:/, "").trim();
const stripped = firstLine
.replace(/^chore(\([^)]+\))?:/, "")
.replace(/\[(skip|ci)(-|\s)(ci|skip)\]/i, "")
.replace(/\((skip|ci)(-|\s)(ci|skip)\)/i, "")
.trim();
return semver.valid(stripped) !== null;
};

Expand Down
18 changes: 18 additions & 0 deletions @commitlint/is-ignored/src/is-ignored.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,24 @@ test("should ignore npm semver commits with footers", () => {
);
});

test("should ignore npm semver commits with CI skip markers", () => {
expect(isIgnored("2.3.3-beta.1 [skip ci]")).toBe(true);
expect(isIgnored("2.3.3-beta.1 [ci skip]")).toBe(true);
expect(isIgnored("2.3.3-beta.1 [skip-ci]")).toBe(true);
expect(isIgnored("2.3.3-beta.1 [ci-skip]")).toBe(true);
expect(isIgnored("2.3.3-beta.1 (skip ci)")).toBe(true);
expect(isIgnored("2.3.3-beta.1 (ci skip)")).toBe(true);
expect(isIgnored("2.3.3-beta.1 (skip-ci)")).toBe(true);
expect(isIgnored("2.3.3-beta.1 (ci-skip)")).toBe(true);
});

test("should ignore npm semver commits with chore and CI skip markers", () => {
expect(isIgnored("chore(release): 2.3.3-beta.1 [skip ci]")).toBe(true);
expect(isIgnored("chore(release): 2.3.3-beta.1 [ci skip]")).toBe(true);
expect(isIgnored("chore: 2.3.3-beta.1 [skip ci]")).toBe(true);
expect(isIgnored("chore: 2.3.3-beta.1 [ci skip]")).toBe(true);
});

test("should return true amend commits", () => {
expect(isIgnored("amend! initial commit")).toBe(true);
});
Expand Down
Loading