Fix/numeric subject case#451
Merged
marionebl merged 2 commits intoconventional-changelog:masterfrom Oct 5, 2018
byCedric:fix/numeric-subject-case
Merged
Fix/numeric subject case#451marionebl merged 2 commits intoconventional-changelog:masterfrom byCedric:fix/numeric-subject-case
marionebl merged 2 commits intoconventional-changelog:masterfrom
byCedric:fix/numeric-subject-case
Conversation
Contributor
|
Thanks! <3 |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes #438
Motivation and Context
I've added edge case-ignores to both
@commitlint/rules's subject-case rule as well as@commitlint/ensure's case. The reason for putting ignores in 2 places are these.You said that we should ignore all characters not matching
/^[a-z]/ifrom the case rules in general.This was my initial thought of putting an ignore/exception into the
/ensurepackage. Unfortunately, this conflicted with the test ofLOWERCASE(with backtick), so I had to change it to ignore/^[0-9]/.In the subject case you can negate the rule
Due to the negation happening in the
/rulespackage, and not/ensure, I had to also include the ignore here. I've tested it with both the!a-zas well as0-9ignore pattern, and here we actually could use the!a-zexclusion rule.subjectCase('1.0.0', 'never', 'lowercase') === truesubjectCase('1.0.0', 'always', 'lowercase') === trueUsage examples
How Has This Been Tested?
See motivation & context
Types of changes
Checklist: