fix(rules): handle blank commit message in signed-off-by rule#4124
Merged
escapedcat merged 1 commit intoconventional-changelog:masterfrom Aug 28, 2024
SetDefaultOne:master
Merged
fix(rules): handle blank commit message in signed-off-by rule#4124escapedcat merged 1 commit intoconventional-changelog:masterfrom SetDefaultOne:master
signed-off-by rule#4124escapedcat merged 1 commit intoconventional-changelog:masterfrom
SetDefaultOne:master
Conversation
Signed-off-by: Default One <[email protected]>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Member
|
Thanks! |
Member
|
Had some issues during the publish but version 19.4.1 should work for you. Give it a try. |
Contributor
Author
Thanks. I've already set up v19.4.1 and it's working as intended. |
This was referenced Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for an empty commit message for rule
signed-off-by.Description
On a minimal environment with only
commitlintinstalled and thesigned-off-byrule set, writing an empty commit message would result in a runtime exception.Motivation and Context
Previously this rule caused a runtime exception trying to validate an empty commit message as it was trying to access the
startsWithstring method on an undefined value which was supposed to store the last line of the commit message. Now it does a check to see if the last line isundefinedor not.Types of changes
Checklist: