fix(config-nx-scopes): include file extension in nx imports#3979
Merged
escapedcat merged 1 commit intoconventional-changelog:masterfrom Mar 16, 2024
timonmasberg:master
Merged
fix(config-nx-scopes): include file extension in nx imports#3979escapedcat merged 1 commit intoconventional-changelog:masterfrom timonmasberg:master
escapedcat merged 1 commit intoconventional-changelog:masterfrom
timonmasberg:master
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
leonardlib
approved these changes
Mar 15, 2024
Member
|
Will publish a release after some other issues got feedback |
Member
|
Also, thanks! |
This was referenced Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the package is now pure ESM, we need to add the file extension to imports from nx as they are not coming from a package.json export field (https://nodejs.org/api/esm.html#esm_mandatory_file_extension).
Description
By adding the file extensions, the modules get resolved again.
Motivation and Context
Fixes #3978
How Has This Been Tested?
Verified on https://github.com/timonmasberg/commitlint-nx-bug, which is a reporduction for the bug.
Types of changes
Checklist: