Skip to content

chore: bump ESM only packages and minor version packages#3927

Merged
escapedcat merged 1 commit intoconventional-changelog:masterfrom
JounQin:feat/esm
Feb 22, 2024
Merged

chore: bump ESM only packages and minor version packages#3927
escapedcat merged 1 commit intoconventional-changelog:masterfrom
JounQin:feat/esm

Conversation

@JounQin
Copy link
Copy Markdown
Collaborator

@JounQin JounQin commented Feb 22, 2024 •
edited
Loading

yarn outdated output after this PR:

Package     Current  Wanted   Latest   Workspace                       Package Type    URL                                                                      
@types/node 18.19.17 18.19.17 20.11.19 @commitlint/cli                 devDependencies https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node
@types/node 18.19.17 18.19.17 20.11.19 @commitlint/load                devDependencies https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node
cosmiconfig 8.3.6    8.3.6    9.0.0    @commitlint/load                dependencies    https://github.com/cosmiconfig/cosmiconfig#readme                        
glob        8.1.0    8.1.0    10.3.10  @commitlint/config-lerna-scopes dependencies    https://github.com/isaacs/node-glob#readme                               
glob        8.1.0    8.1.0    10.3.10  @commitlint/config-patternplate dependencies    https://github.com/isaacs/node-glob#readme                               
glob        8.1.0    8.1.0    10.3.10  @commitlint/ensure              devDependencies https://github.com/isaacs/node-glob#readme                               
glob        8.1.0    8.1.0    10.3.10  @commitlint/rules               devDependencies https://github.com/isaacs/node-glob#readme                               
lerna       6.4.1    6.6.2    8.1.2    @commitlint/root                devDependencies https://lerna.js.org                                                     
prettier    2.8.8    2.8.8    3.2.5    @commitlint/root                devDependencies https://prettier.io

I'll continue upgrading above packages in another PR.

Question: Should we upgrade @types/node to latest version or stick on v18?

@escapedcat
Copy link
Copy Markdown
Member

escapedcat commented Feb 22, 2024

Question: Should we upgrade @types/node to latest version or stick on v18?

My current handling is that we use teh types for the lowest supported version (v18). Does this make sense?

Thanks for you work!
We do not need to update all deps everything before doing a release. Let me know when you think we're far enough.

@escapedcat escapedcat merged commit b7254bf into conventional-changelog:master Feb 22, 2024
@JounQin
Copy link
Copy Markdown
Collaborator Author

JounQin commented Feb 22, 2024

My current handling is that we use teh types for the lowest supported version (v18). Does this make sense?

Sure!

We do not need to update all deps everything before doing a release. Let me know when you think we're far enough.

In case we're doing a major release, so I think it's a good time to upgrade dependencies.

I'm holding on cosmiconfig because it changes its config search strategy on v9: https://github.com/cosmiconfig/cosmiconfig/blob/main/CHANGELOG.md#900

glob is rewritten and some internal things changed, although the functionality is not affected anyway.

What do you think about these remaining dependencies?

@escapedcat

@JounQin JounQin deleted the feat/esm branch February 22, 2024 15:10
@escapedcat
Copy link
Copy Markdown
Member

escapedcat commented Feb 22, 2024

I'm good with the current state. Rather release sooner than later to unblock waiting PRs. wdyt?

@JounQin
Copy link
Copy Markdown
Collaborator Author

JounQin commented Feb 22, 2024

I'd like to wait for a while for cosmiconfig/cosmiconfig#339 and upgrade glob shortly.

AFAIK, we're not in an emergency situation, right?

@escapedcat
Copy link
Copy Markdown
Member

escapedcat commented Feb 22, 2024

AFAIK, we're not in an emergency situation, right?

:D No, none of this is an emergency 🙌

I'd like to wait for a while for cosmiconfig/cosmiconfig#339 and upgrade glob shortly.

Sure, go ahead.
Might be good to wait with upgrading lerna/prettier. Had some related issue in the past which was only blocking publishing a release. Which was annoying.

escapedcat pushed a commit that referenced this pull request Feb 27, 2024
@JounQin @escapedcat
chore: bump ESM only packages and minor version packages (#3927)
42d90f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JounQin @escapedcat