Pin cosmiconfig to specific version#3755
Merged
escapedcat merged 9 commits intoconventional-changelog:masterfrom Nov 12, 2023
Merged
Pin cosmiconfig to specific version#3755escapedcat merged 9 commits intoconventional-changelog:masterfrom
escapedcat merged 9 commits intoconventional-changelog:masterfrom
Conversation
…pendency for @commitlint/load
escapedcat
reviewed
Nov 11, 2023
Member
|
Thanks @joberstein and @newives ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pin cosmiconfig to specific version.
Motivation and Context
Yarn at least (maybe npm also?) doesn't update transitive dependencies, so any consuming apps that had installed a lower version of 8.x.x would face an issue by not pinning to a specific dependency because yarn won't update transitive dependencies if the installed one satisfies the requirement (e.g. 8.0.0 will satisfy ^8.0.0 even if it's not the latest 8.x.x).
Pinning a specific version so that installers will be forced to install the new version of comsiconfig when updating commitlint/cli or commitlint/load.
Resolves:
Caused by:
Usage examples
N/A
How Has This Been Tested?
Tested locally by installing the updated version in https://github.com/mikro-orm/mikro-orm which was facing this issue.
Types of changes
Checklist: