Skip to content

feat(load): use cosmiconfig-typescript-loader v5 to remove ts-node dependency#3722

Merged
escapedcat merged 2 commits intoconventional-changelog:masterfrom
joberstein:feat/bump-cosmiconfig-typescript-loader-2
Oct 26, 2023
Merged

feat(load): use cosmiconfig-typescript-loader v5 to remove ts-node dependency#3722
escapedcat merged 2 commits intoconventional-changelog:masterfrom
joberstein:feat/bump-cosmiconfig-typescript-loader-2

Conversation

@joberstein
Copy link
Copy Markdown
Contributor

Link to original PR: #3633

Just re-applying the changes.

Comment thread @commitlint/load/package.json Outdated
@joberstein
Copy link
Copy Markdown
Contributor Author

@escapedcat I still need to re-test this locally but I think I've re-applied the necessary changes.

@escapedcat
Copy link
Copy Markdown
Member

@escapedcat I still need to re-test this locally but I think I've re-applied the necessary changes.

Thanks! Let me know when you think it can be merged.
This is not a breaking change for others, right? Just want to double check that.

@joberstein
Copy link
Copy Markdown
Contributor Author

@escapedcat I still need to re-test this locally but I think I've re-applied the necessary changes.

Thanks! Let me know when you think it can be merged. This is not a breaking change for others, right? Just want to double check that.

It should not be breaking, now that node >= 16 is required, but I'll take another look at the changelog also.

@joberstein joberstein changed the base branch from master to renovate/tar-fs-3.x October 26, 2023 03:12
@joberstein joberstein changed the base branch from renovate/tar-fs-3.x to master October 26, 2023 03:12
@escapedcat
Copy link
Copy Markdown
Member

Changelog looks good. Will merge again :P

@escapedcat escapedcat merged commit 1ff49ea into conventional-changelog:master Oct 26, 2023
@escapedcat
Copy link
Copy Markdown
Member

@joberstein
Copy link
Copy Markdown
Contributor Author

I didn't get a chance to test it out yesterday but I didn't see any other breaking changes yesterday (only additive like support for Esm).

I'll test it out today but it's pretty identical to the original.

@joberstein
Copy link
Copy Markdown
Contributor Author

@escapedcat seems like it's working well, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants