feat(rules): support array for scope-case and type-case#312
Merged
marionebl merged 1 commit intoconventional-changelog:masterfrom May 1, 2018
Merged
Conversation
As per issue conventional-changelog#307 port the logic from subject-case for array definitions over to scope-case and type-case.
Contributor
Author
|
@marionebl sorry to bug you, any chance of getting this merged/reviewed anytime soon? |
Contributor
|
Will have a look at this tomorrow, thanks for your patience! |
4 tasks
marceloavf
approved these changes
Apr 26, 2018
|
@SimeonC I don't think you need to update documentation since it already show an example with array |
Contributor
|
Thanks for your patience people, merging this. |
Contributor
|
Released via 6.2.0 |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've changed the scope-case and type-case rules to follow the same option for providing arrays in the rule value as is used in subject-case. Additionally, I've added tests to all 3 rules to check for this use case.
Motivation and Context
As outlined in #307 it's really useful to be able to use a mixture of scope casing types when you use file/folder names as the scope.
Usage examples
This is my specific use case.
How Has This Been Tested?
Added test suites that passed under subject-case, then copy/tweaked them to the other files to check that they all worked in the same way.
Types of changes
Checklist: