docs: husky add .husky/commit-msg docs fix#3113
Merged
escapedcat merged 2 commits intoconventional-changelog:masterfrom Apr 23, 2022
sdzialowski-godaddy:patch-1
Merged
docs: husky add .husky/commit-msg docs fix#3113escapedcat merged 2 commits intoconventional-changelog:masterfrom sdzialowski-godaddy:patch-1
escapedcat merged 2 commits intoconventional-changelog:masterfrom
sdzialowski-godaddy:patch-1
Conversation
Member
|
Thanks! On which environment did this happen? @fzn0x did the current changes I believe. Maybe fzn0x has some feedback. |
Executing ``` npx husky add .husky/commit-msg 'npx --no -- commitlint --edit $1' yarn husky add .husky/commit-msg 'yarn commitlint --edit $1' ``` doesn't seem to produce desired .husky/commit-msg file content ``` . "$(dirname "$0")/_/husky.sh" npx --no -- commitlint --edit $1 ``` instead it produces ``` . "$(dirname "$0")/_/husky.sh" npx --no -- commitlint --edit ``` because $1 is interpolated, adding slash doesn't seem to help, hence suggested fix (fix is bit ugly I admit, up to you guys to accept it or fixing it your way)
Member
|
Thanks @sd-godaddy ! |
This was referenced Apr 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executing
doesn't seem to produce desired .husky/commit-msg file content
instead it produces
because $1 is interpolated, adding slash doesn't seem to help, hence suggested fix (fix is bit ugly I admit, up to you guys to accept it or fixing it your way)
Description
Motivation and Context
Usage examples
How Has This Been Tested?
Types of changes
Checklist: