Skip to content

Ignoring node_modules folders inside nested workspaces as Lerna scopes#3025

Merged
escapedcat merged 2 commits intoconventional-changelog:masterfrom
emredoganm:bugfix/ignore-node-modules
Feb 14, 2022
Merged

Ignoring node_modules folders inside nested workspaces as Lerna scopes#3025
escapedcat merged 2 commits intoconventional-changelog:masterfrom
emredoganm:bugfix/ignore-node-modules

Conversation

@emredoganm
Copy link
Copy Markdown
Contributor

@emredoganm emredoganm commented Feb 13, 2022

Description

For nested workspaces, the config rules also gave the name of the packages' dependencies as Lerna scope.

Motivation and Context

The issue of #3023

Usage examples

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat
Copy link
Copy Markdown
Member

escapedcat commented Feb 14, 2022

Thanks @emredoganm ! Awesome!

@escapedcat escapedcat merged commit e597735 into conventional-changelog:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emredoganm @escapedcat